Integrate CaptureArbitrumStorageGet/Set into the prestate tracer #2602
+191
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
changed the title
…toragegetset-prestatetracer
…toragegetset-prestatetracer
diegoximenes
reviewed
Nov 7, 2024
diegoximenes
approved these changes
Nov 19, 2024
| @@ -141,9 +140,16 @@ func TestPrestateTracerArbitrumStorage(t *testing.T) { | |||
| hourNow := (time.Now().Unix() - programs.ArbitrumStartTime) / 3600 | |||
| hourActivatedFromTrace := arbmath.BytesToUint24(postData[8:11]) | |||
| // #nosec G115 | |||
| assert(uint64(hourActivatedFromTrace) == uint64(hourNow), nil, "wrong activated time in trace") | |||
| if !(uint64(hourActivatedFromTrace) == uint64(hourNow)) { | |||
There was a problem hiding this comment.
nitpick: this if is not needed
There was a problem hiding this comment.
i had left it there thinking it signifies we are looking for equality check (most cases) here. But we kind need to have two checks anyway as we should check if math.Abs(float64(hourActivatedFromTrace)-float64(hourNow)) is either 0 or 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
CaptureArbitrumStorage[Get]Setmethods forprestateTracercapturing changes that ArbOS makes to storage outside EVM execution, these weren't picked up by theprestateTracerbefore.Arbos
Storageobject callsRecordStorage[Get]Setfunctions to capture tracing of reads and writes of key-value pairs, meaning the SLOAD/SSTORE opcodes tracing in these functions during scenarioTracingDuringEVMhas no impact at all as the caller address (scope.Contract) and the key being passed don't associate with each other, instead the key corresponds to types.ArbosStateAddress.To solve this issue, we currently call
CaptureArbitrumStorage[Get]Setregardless of the tracing scenario and call opcode tracing additionally if the scenario isTracingDuringEVMto preserve functionality of other tracers that haven't yet implementedCaptureArbitrumStorage...methods. Notice that SLOAD/SSTORE opcode tracing has no effect on prestate tracer due to the above stated issue and callingCaptureArbitrumStorage...methods first yields correct results.Pulls in geth- OffchainLabs/go-ethereum#352
Resolves NIT-2733